fix donutty.js #21
Open
fix donutty.js #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @TemporaryTetra I kind of get what the problem is, as
By your code, the ability to pass in a |
simeydotme
requested changes
Jan 15, 2021
| @@ -22,7 +22,7 @@ | |||
|
|
|||
| this.$wrapper = doc.querySelectorAll( el )[0]; | |||
|
|
|||
| } else if ( el instanceof window.HTMLElement ) { | |||
| } else if ( doc.querySelector( `.${el.className}` ) ) { | |||
There was a problem hiding this comment.
this should be;
} else if ( el instanceof HTMLIFrameElement || el instanceof HTMLElement ) {
|
Thanks for the quick reply, I also tried HTMLIFrameElement but this check
doesn't see my wrapper class.
https://i.imgur.com/uHCSZ2n.png
пт, 15 січ. 2021 о 17:28 Simon Goellner <notifications@github.com> пише:
… ***@***.**** requested changes on this pull request.
Please make the change suggested and I can build and test
------------------------------
In src/donutty.js
<#21 (comment)>:
> @@ -22,7 +22,7 @@
this.$wrapper = doc.querySelectorAll( el )[0];
- } else if ( el instanceof window.HTMLElement ) {
+ } else if ( doc.querySelector( `.${el.className}` ) ) {
this should be;
} else if ( el instanceof HTMLIFrameElement || el instanceof HTMLElement ) {
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#21 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALEM52RD32G2EQOAYBTTENLS2BNJZANCNFSM4WDV4U6Q>
.
|
|
But the way it works on the front end is correct
https://i.imgur.com/uHCSZ2n.png
пт, 15 січ. 2021 о 21:26 Nikolai Nasibullin <zedoir1@gmail.com> пише:
… Thanks for the quick reply, I also tried HTMLIFrameElement but this check
doesn't see my wrapper class.
https://i.imgur.com/uHCSZ2n.png
пт, 15 січ. 2021 о 17:28 Simon Goellner ***@***.***> пише:
> ***@***.**** requested changes on this pull request.
>
> Please make the change suggested and I can build and test
> ------------------------------
>
> In src/donutty.js
> <#21 (comment)>:
>
> > @@ -22,7 +22,7 @@
>
> this.$wrapper = doc.querySelectorAll( el )[0];
>
> - } else if ( el instanceof window.HTMLElement ) {
> + } else if ( doc.querySelector( `.${el.className}` ) ) {
>
> this should be;
>
> } else if ( el instanceof HTMLIFrameElement || el instanceof HTMLElement ) {
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#21 (review)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ALEM52RD32G2EQOAYBTTENLS2BNJZANCNFSM4WDV4U6Q>
> .
>
|
|
Sorry, I totally don't understand what that means, are you able to show me a reduced test case in CodeSandbox or something? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for
HTMLElementdoes not work correctly ifelis in an iframe. Since iframe creates a new space.Therefore, in this case, it will be better to check if
elexists in the document.