8000 Get tests to pass with `pytest -Werror` · Issue #541 · simonw/sqlite-utils · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Get tests to pass with pytest -Werror #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
simonw opened this issue May 8, 2023 · 2 comments
Open

Get tests to pass with pytest -Werror #541

simonw opened this issue May 8, 2023 · 2 comments
Labels
ci help wanted Extra attention is needed

Comments

@simonw
Copy link
Owner
simonw commented May 8, 2023

Inspired by:
@simonw simonw added help wanted Extra attention is needed ci labels May 8, 2023
simonw added a commit that referenced this issue May 8, 2023
@simonw
Fix a bunch of warnings in the tests, refs #541
a256d7d
@simonw
Copy link
Owner Author
simonw commented May 8, 2023

There are 8 failing tests left:

==== short test summary info ====
FAILED tests/test_cli_memory.py::test_memory_csv[False-test] - pytest.PytestUnraisableExceptionWarning: Exception ignored in: <_io.FileIO [closed]>
FAILED tests/test_cli_memory.py::test_memory_csv[False-t] - pytest.PytestUnraisableExceptionWarning: Exception ignored in: <_io.FileIO [closed]>
FAILED tests/test_cli_memory.py::test_memory_csv[False-t1] - pytest.PytestUnraisableExceptionWarning: Exception ignored in: <_io.FileIO [closed]>
FAILED tests/test_cli_memory.py::test_memory_tsv[False] - pytest.PytestUnraisableExceptionWarning: Exception ignored in: <_io.FileIO [closed]>
FAILED tests/test_cli_memory.py::test_memory_dump[extra_args0] - pytest.PytestUnraisableExceptionWarning: Exception ignored in: <_io.FileIO [closed]>
FAILED tests/test_cli_memory.py::test_memory_two_files_with_same_stem - pytest.PytestUnraisableExceptionWarning: Exception ignored in: <_io.FileIO [closed]>
FAILED tests/test_recipes.py::test_dateparse_errors[None-parsedate] - pytest.PytestUnraisableExceptionWarning: Exception ignored in: <function Table.convert.<locals>.convert_value at 0x106bcaca0>
FAILED tests/test_recipes.py::test_dateparse_errors[None-parsedatetime] - pytest.PytestUnraisableExceptionWarning: Exception ignored in: <function Table.convert.<locals>.convert_value at 0x106bc9620>
ERROR tests/test_cli.py::test_upsert_analyze - pytest.PytestUnraisableExceptionWarning: Exception ignored in: <_io.FileIO [closed]>
==== 8 failed, 894 passed, 4 skipped, 1 error in 6.27s ====

Full traceback here: https://gist.github.com/simonw/b40b3e814729d6c02a0302a84ce54d9e

@lbellomo
Copy link

I made a new run and found a few more cases. I can try to make a PR to fix them.

==== short test summary info ====
FAILED tests/test_cli.py::test_upsert_analyze - pytest.PytestUnraisableExceptionWarning: Exception ignored in: <_io.FileIO ...
FAILED tests/test_cli_memory.py::test_memory_csv[False-test] - pytest.PytestUnraisableExceptionWarning: Exception ignored in: <_io.FileIO ...
FAILED tests/test_cli_memory.py::test_memory_csv[False-t] - pytest.PytestUnraisableExceptionWarning: Exception ignored in: <_io.FileIO ...
FAILED tests/test_cli_memory.py::test_memory_csv[False-t1] - pytest.PytestUnraisableExceptionWarning: Exception ignored in: <_io.FileIO ...
FAILED tests/test_cli_memory.py::test_memory_tsv[False] - pytest.PytestUnraisableExceptionWarning: Exception ignored in: <_io.FileIO ...
FAILED tests/test_cli_memory.py::test_memory_dump[extra_args1] - pytest.PytestUnraisableExceptionWarning: Exception ignored in: <_io.FileIO ...
FAILED tests/test_cli_memory.py::test_memory_two_files_with_same_stem - pytest.PytestUnraisableExceptionWarning: Exception ignored in: <_io.FileIO ...
FAILED tests/test_insert_files.py::test_insert_files[pk_args0-expected_pks0-False] - DeprecationWarning: datetime.datetime.utcfromtimestamp() is deprecated and ...
FAILED tests/test_insert_files.py::test_insert_files[pk_args0-expected_pks0-True] - DeprecationWarning: datetime.datetime.utcfromtimestamp() is deprecated and ...
FAILED tests/test_insert_files.py::test_insert_files[pk_args1-expected_pks1-False] - DeprecationWarning: datetime.datetime.utcfromtimestamp() is deprecated and ...
FAILED tests/test_insert_files.py::test_insert_files[pk_args1-expected_pks1-True] - DeprecationWarning: datetime.datetime.utcfromtimestamp() is deprecated and ...
FAILED tests/test_recipes.py::test_dateparse_errors[None-parsedate] - pytest.PytestUnraisableExceptionWarning: Exception ignored in: <function Ta...
FAILED tests/test_recipes.py::test_dateparse_errors[None-parsedatetime] - pytest.PytestUnraisableExceptionWarning: Exception ignored in: <function Ta...
==== 13 failed, 972 passed, 16 skipped in 10.54s =====

@lbellomo lbellomo mentioned this issue Mar 31, 2024
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simonw @lbellomo
0