8000 cache-control: private is playing havoc with performance · Issue #47 · simonw/datasette-auth-github · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

cache-control: private is playing havoc with performance #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
simonw opened this issue Oct 7, 2019 · 2 comments
Closed

cache-control: private is playing havoc with performance #47

simonw opened this issue Oct 7, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@simonw
Copy link
Owner
simonw commented Oct 7, 2019

In #6 we disabled all caching for logged in users.

datasette-auth-github/datasette_auth_github/github_auth.py

Lines 138 to 145 in b3aaa4c

# Rebuild headers to include cache-control: private
original_headers = event.get("headers") or []
new_headers = [
[key, value]
for key, value in original_headers
if key.lower() != b"cache-control"
]
new_headers.append([b"cache-control", b"private"])

It turns out this is causing really nasty performance issues when running with other plugins such as datasette-vega! See simonw/datasette#586
@simonw simonw added the bug Something isn't working label Oct 7, 2019
@simonw simonw mentioned this issue Oct 7, 2019
Closed
@simonw
Copy link
Owner Author
simonw commented Oct 7, 2019 •
edited
Loading

github__repos__32_rows_where_where_private___1

@simonw
Copy link
Owner Author
simonw commented Oct 7, 2019

I'm going to fix this by having the code NOT apply cache-control: private to anything within the /-/static directory - but only when the ASGI middleware is being used by Datasette.

This means I'll add an opt-out mechani 8000 sm that other users of the middleware can potentially tap into.

simonw added a commit that referenced this issue Oct 7, 2019
@simonw
Implemented cacheable_assets, refs #47
562c286
@simonw simonw mentioned this issue Oct 7, 2019
Merged
1 task
simonw added a commit that referenced this issue Oct 7, 2019
@simonw
Documentation for cacheable_prefixes, refs #47
211f820
@simonw simonw closed this as completed in e4334d7 Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonw
0