8000 Allow id prop to get passed to the React SelectionArea component by Olivia-li · Pull Request #176 · simonwep/viselect · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Allow id prop to get passed to the React SelectionArea component #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2022
Merged

Allow id prop to get passed to the React SelectionArea component #176

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/react/src/SelectionArea.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import {SelectionEvents, SelectionOptions} from '@vanilla/types';
import React, {createRef, useEffect} from 'react';

export interface SelectionAreaProps extends Omit<Partial<SelectionOptions>, 'boundaries'>, React.HTMLAttributes<HTMLDivElement> {
id?: string;
className?: string;
onBeforeStart?: SelectionEvents['beforestart'];
onStart?: SelectionEvents['start'];
Expand Down Expand Up @@ -32,7 +33,7 @@ export const SelectionArea: React.FunctionComponent<SelectionAreaProps> = props
}, []);

return (
<div ref={root} className={props.className}>
<div ref={root} className={props.className} id={props.id} >
{props.children}
</div>
);
Expand Down
0