Fix/empty docset #580
Draft
Fix/empty docset #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If catalog query fails, it most likely means there are no traditional books in the queried docSet. Adding a dummy docSet with the appropriate docSetID, language code, and book collection ID, still allows for a catalog entry to be created such that quizzes can still be added.
If a book collection does not have any traditional books, Proskomma will not have a docSet to write to a pkf file. THIS CHANGE WILL BREAK SEVERAL THINGS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per @chrisvire 's request, moved some changes from PR #571 to a new PR.
In some cases when attempting to implement quizzes, a data set was used which contained book collections that only had quizzes. This PR is an attempt to fix the problems that arose during the conversion process on those data sets.
While this fixes those problems, I am very certain that the chosen solution, not writing a pkf when there is no Proskomma docSet, will break many things in the app itself.
Pretty much everything in
src/lib/data/scripture.jsis likely to break from this change, which will also probably cause problems insrc/routes/+page.svelte.One potential solution that could fix those issues would be extending
src/lib/sab-proskommato be able to handle an empty pkf, and then make sure an empty pkf is written instead of no pkf.The main reason this PR exists is because we have data sets that cause this problem. It may be the case that something should be changed in Scripture App Builder itself to prevent the creation of data sets that cause this problem in the first place.