8000 use navigator clipboard if has support #510 by Luisgustavom1 · Pull Request #514 · silevis/reactgrid · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

use navigator clipboard if has support #510 #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 25, 2025
Merged

use navigator clipboard if has support #510 #514

merged 2 commits into from
Mar 25, 2025

Conversation

Luisgustavom1
Copy link
Contributor
@Luisgustavom1 Luisgustavom1 commented Mar 14, 2025 •
edited
Loading

This PR is to fix this issues on chrome 134.*

Recent updates on chrome (134.* > ) broken the .execCommand in some cases, as reported in some issues like this one https://issues.chromium.org/issues/401379144

#509
#507

@Luisgustavom1 Luisgustavom1 force-pushed the fix/copy-paste-on-chrome-134 branch from 5c1eff6 to f4c7854 Compare March 14, 2025 11:08
@Luisgustavom1 Luisgustavom1 mentioned this pull request Mar 14, 2025
Merged
Luisgustavom1
Luisgustavom1 commented Mar 14, 2025
View reviewed changes
src/lib/Functions/handleCopy.ts
const clipboardItem = new ClipboardItem(clipboardItemData);
await navigator.clipboard.write([clipboardItem]);
navigator.clipboard.write([clipboardItem]).then(() => ({}));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the best way to handle promises on Behavior class?

To not change architecture and turn this method a promise, I only handle promise of clipboard.write with .then

What's the project pattern to handle errors? We let the error pop up for the user to handle? We take it and treat it directly at the lib?

@salah-khan-g3
Copy link

If anyone can give us a ETA, that would be nice.

@Luisgustavom1
Copy link
Contributor Author

If anyone can give us a ETA, that would be nice.

for sure

@dilyan-atanasov
Copy link

When will this be applied so that we can remove our temporary solutions?

@arasovic
Copy link

hello @webloopbox
do you have a timeline for the next version or patch? like v4.1.16 or something
could you provide any information about it?

@webloopbox
Copy link
Contributor

We'll release version 4.1.16, which includes a fix for this issue, at the beginning of next week

@Luisgustavom1
Copy link
Contributor Author

We'll release version 4.1.16, which includes a fix for this issue, at the beginning of next week

great news

@MichaelMatejko MichaelMatejko merged commit eeef7ba into silevis:develop Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelMatejko MichaelMatejko MichaelMatejko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Luisgustavom1 @salah-khan-g3 @dilyan-atanasov @arasovic @webloopbox @MichaelMatejko
0