8000 Fixed issue-1600 add thread-safe protection to inputManager by hushengyue · Pull Request #1604 · siddhi-io/siddhi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixed issue-1600 add thread-safe protection to inputManager #1604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 6, 2020
Merged

Fixed issue-1600 add thread-safe protection to inputManager #1604

merged 9 commits into from
Jan 6, 2020

Conversation

hushengyue
Copy link

Fixed issue-1600 by adding synchronized protection

@claassistantio
Copy link
claassistantio commented Jan 2, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link
codecov-io commented Jan 2, 2020 •
edited
Loading

Codecov Report

Merging #1604 into master will decrease coverage by <.01%.
The diff coverage is 75%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1604      +/-   ##
============================================
- Coverage     67.89%   67.89%   -0.01%     
  Complexity       45       45              
============================================
  Files           654      654              
  Lines         27982    27986       +4     
  Branches       4403     4404       +1     
============================================
+ Hits          18999    19000       +1     
- Misses         7155     7156       +1     
- Partials       1828     1830       +2
Impacted Files Coverage Δ Complexity Δ
...java/io/siddhi/core/stream/input/InputManager.java 89.47% <75%> (-4.65%) 0 <0> (ø)
...c/main/java/io/siddhi/core/util/ThreadBarrier.java 80% <0%> (-20%) 0% <0%> (ø)
.../processor/stream/window/DelayWindowProcessor.java 78.18% <0%> (-5.46%) 0% <0%> (ø)
...istence/IncrementalFileSystemPersistenceStore.java 50.96% <0%> (-0.97%) 0% <0%> (ø)
...o/siddhi/core/aggregation/IncrementalExecutor.java 80.46% <0%> (-0.79%) 0% <0%> (ø)
.../io/siddhi/core/util/snapshot/SnapshotService.java 71.63% <0%> (+1.03%) 0% <0%> (ø) ⬇️
...ore/util/persistence/InMemoryPersistenceStore.java 58.97% <0%> (+5.12%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a47397e...e7e87eb. Read the comment docs.

dependabot-preview bot and others added 6 commits January 2, 2020 15:13
@dependabot-preview
Bump classindex from 3.8 to 3.9
31cdc73 
Bumps [classindex](https://github.com/atteo/classindex) from 3.8 to 3.9.
- [Release notes](https://github.com/atteo/classindex/releases)
- [Changelog](https://github.com/atteo/classindex/blob/master/CHANGES.md)
- [Commits](atteo/classindex@3.8...3.9)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@mohanvive
Merge pull request siddhi-io#1598 from siddhi-io/dependabot/maven/org…
f574833 
….apache.maven.plugins-maven-source-plugin-3.2.1

Bump maven-source-plugin from 3.2.0 to 3.2.1
@mohanvive
Merge pull request siddhi-io#1606 from siddhi-io/dependabot/maven/org…
a47397e 
….atteo.classindex-classindex-3.9

Bump classindex from 3.8 to 3.9
@daniel-husy
Fixed issue-1600 add thread-safe protection to inputManager
d32fe88
@daniel-husy
Fixed issue-1600 fix error found by unit test case
6accaa9
@daniel-husy
Merge branch 'issue-1600' of https://github.com/hushengyue/siddhi int…
e7e87eb 
…o issue-1600
@mohanvive mohanvive requested a review from suhothayan January 6, 2020 04:11
@mohanvive
Copy link
Contributor

Thanks for the PR @hushengyue ... We'll review and get it merged ASAP..

@mohanvive mohanvive merged commit f1ef77f into siddhi-io:master Jan 6, 2020
@mohanvive
Copy link
Contributor

PR is merged. @hushengyue Thanks for your contribution. Appreciate it..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohanvive mohanvive mohanvive approved these changes

@suhothayan suhothayan Awaiting requested review from suhothayan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hushengyue @claassistantio @codecov-io @mohanvive @daniel-husy
0