Mobile UI Improvements #161
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for all of the merge conflicts here 😱. Excited to test this out |
samouri
reviewed
Mar 23, 2025
| @@ -76,7 +76,10 @@ function deriveState(state: GivenState): State { | |||
| const notes: SongNote[] = items | |||
| ? (items.filter((i) => i.type === 'note') as SongNote[]) | |||
| : ([{ midiNote: 21 }, { midiNote: 108 }] as SongNote[]) | |||
| const { startNote, endNote } = getSongRange({ notes }) | |||
|
|
|||
| const minNotes = Math.floor(Math.max(36, 50 * ( state.windowWidth / state.height))) | |||
There was a problem hiding this comment.
Can you explain this logic?
There was a problem hiding this comment.
I think the logic I would want is something similar to setting a maxWidth on the piano keys, as well as having a "minHeight" for the falling notes viewport
Merged
|
@ginesdt: I really like this PR! Would love to incorporate fullscreen mode, make viewing better on phones/iPads, and collapsible toparea. I think this feature would benefit from being split into multiple to make it easier to ensure quality on the different parts. I've extracted the least controversial commits to a separate feature (#167) for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the user experience on small devices (e.g., smartphones) and touchscreens. The updates ensure better screen utilization, and improved responsiveness across various device sizes.
Changes Made:
Zoom out f 8000 or wide screens: Optimized scaling for wider displays. You were not able to see the falling notes.
Added fullscreen toggle button: Allows users to easily enter/exit fullscreen to have more space to visualize notes.
Added button to hide top menu bar: Gives users the option to hide the top menu for the same purpose.
Automatically collapse menu for small screens: Prevent icons to paint on top of each other in small screens.
Other fixes, like ensure the song list is visible in small screens or make the scrub bar draggable on touchscreens.
Overall, it goes from this:
To this: