WIP removed the apparently-unnecessary anyOf blocks #338
Conversation
|
I think you should include the indent changes here too. I usually do a round-trip in python but I think people also use |
sigmf-schema.json
Outdated
| @@ -76,7 +91,7 @@ | |||
| "default": 0, | |||
| "minimum": 0, | |||
| "!comment": "The maximum value for this property is equal to 2^63 - 1, making it easy to fit into a signed 64-bit integer.", | |||
| "maximum": 9223372036854775807, | |||
| "maximum": 9223372036854776000, | |||
There was a problem hiding this comment.
I don't think you meant to change these. This number is 2**63 + 192. Was previously max signed integer.
|
:-O blames |
|
I suppose if we were smart we would use an integer small enough such that |
|
I now notice that the jq-ification rewrote 1e12 -> 1000000000000 which I dislike |
|
Looking for feedback from @777arc (or anyone who can give these changes a spin). |
|
FYI you can see the rendered docs by going to the "Build docs" check then clicking Summary on the left, then click "compiled_docs", and open sigmf-spec.html. The core:sample_rate renders the same, everything seems to render the same. |
Note that (for clarity on the substantive edits) this does not include appropriate indent-level changes.
Closes #337