8000 [BUG] Inconsistent SVG size · Issue #87 · shravan20/github-readme-quotes · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[BUG] Inconsistent SVG size #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ShubhKotnala opened this issue Dec 3, 2020 · 1 comment · Fixed by #88, #90 or #82
Closed

[BUG] Inconsistent SVG size #87

ShubhKotnala opened this issue Dec 3, 2020 · 1 comment · Fixed by #88, #90 or #82
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed Little work This task takes little time to complete. (ETA couple of days)
Milestone
Release of V2.0

Comments

@ShubhKotnala
Copy link
Contributor

Describe the bug
The svg image returned from the server is of a static size 700x300 which makes it difficult to align properly with the content since the extra space is filled with transparent background, which makes that space unusable.

To Reproduce
Steps to reproduce the behavior:

  1. Generate any quote with any layout.
  2. Check the size of the image, and the actual content size of the image.

Expected behavior
svg size is expected to be the same as the necessary content.

Screenshots
image
@shravan20 shravan20 added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed Little work This task takes little time to complete. (ETA couple of days) labels Dec 3, 2020
@shravan20 shravan20 added this to the Release of V2.0 milestone Dec 3, 2020
nishantpersonal added a commit that referenced this issue Dec 5, 2020
@nishantpersonal
[Svg Height] fix Svg height issue fixed.Closes #87
0419180
@shravan20 shravan20 linked a pull request Dec 5, 2020 that will close this issue
Svg height issue fix #88
Merged
nishantpersonal added a commit that referenced this issue Dec 5, 2020
@nishantpersonal
[Svg height] fix Dynamic height generation for svg.Closes #87
39cb171
nishantpersonal added a commit that referenced this issue Dec 5, 2020
@nishantpersonal
[Svg height] fix Dynamic height calculation for svg. Closes #87
46eb97e
@shravan20 shravan20 linked a pull request Dec 5, 2020 that will close this issue
Dynamic height calculation for svg. Closes #87 #90
Merged
shravan20 added a commit that referenced this issue Dec 5, 2020
@shravan20
Merge pull request #90 from shravan20/height-issue
3976243 
Dynamic height calculation for svg. Closes #87
@shravan20
Copy link
Owner

Issues solved #90
Thank you for the raising the issue.

@shravan20 8000 shravan20 linked a pull request Dec 5, 2020 that will close this issue
Development | Custom Quotes Feature extracting from Github Gists #82
Merged
nishantpersonal added a commit that referenced this issue Dec 5, 2020
@shravan20 @ShubhankarNineleaps
@ShubhKotnala @nishantpersonal
Development | Custom Quotes Feature extracting from Github Gists (#82)
2edfc54 
* Added Custom Quotes File

* Added validateUrl.js to validate the url from url parameter

* Added support to handle custom quotes from url

* Updated readme for custom quotes

* Initial React Setup with Basic Functionality

* Configured meta data

* Added view of all layouts available

* Configured to serve static frontend files

* Updated Readme

* [Svg Height] fix Svg height issue fixed.Closes #87

* Revert "Svg height issue fix "

* [Svg height] fix Dynamic height calculation for svg. Closes #87

* Updated /src/api/services/quoteService.js

* [ Category Feature ] | Feature | Added customQuotes/category.json && /quotesController.js && /quoteService.js

* [Category Quotes] feature Added quotes for motivational and fun categories

* [ Major Docs Updated ] | Documentation | updated ./README.md

* [ Major Docs Updated ] | Documentation | updated ./README.md

* [ Major Docs Updated ] | Documentation | updated ./README.md

* [ Major Docs Updated ] | Documentation | updated ./README.md

* [ Major Docs Updated ] | Documentation | updated ./README.md

* [ Major Docs Updated ] | Documentation | updated ./README.md

* Added life,success,general,programming categories for custom quotes

* [ Major Docs Updated ] | Documentation | updated ./README.md

* [ Major Docs Updated ] | Documentation | updated ./README.md

* [ Major Docs Updated ] | Documentation | updated ./README.md

* [ Major Docs Updated ] | Documentation | updated ./README.md

* Create label.yml

* Update README.md

Co-authored-by: ShubhankarNineleaps <shubhankar.kotnala@nineleaps.com>
Co-authored-by: Shubhankar Kotnala <skshubhankar@gmail.com>
Co-authored-by: nishantpersonal <nishantvenugopalnair@gmail.com>
Co-authored-by: Nishant Venugopal <67575384+nishantpersonal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed Little work This task takes little time to complete. (ETA couple of days)
Projects
None yet
Milestone
Release of V2.0
2 participants
@ShubhKotnala @shravan20
0