8000 Dark Theme for the website · Issue #120 · shravan20/github-readme-quotes · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Dark Theme for the website #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shravan20 opened this issue Apr 17, 2021 · 6 comments · Fixed by #121
Closed

Dark Theme for the website #120

shravan20 opened this issue Apr 17, 2021 · 6 comments · Fixed by #121
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed Medium work This task takes little time to complete. (ETA week or two)

Comments

@shravan20
Copy link
Owner

Is your feature request related to a problem? Please describe.
Implementation of the Dark Theme for the React Website for Github Readme Quotes, to get a view of how the card looks in the Dark theme of the Github API
@shravan20 shravan20 added help wanted Extra attention is needed good first issue Good for newcomers Medium work This task takes little time to complete. (ETA week or two) labels Apr 17, 2021
@koskrit
Copy link
Contributor
koskrit commented Apr 22, 2021

Hi Shravan, I'd like to help with this issue.

Since this app is using Material-UI, I could try to implement custom global themes.
More Precisely:

  • Add a ThemeProvider at Dashboard
  • Import custom Global theme objects
  • Add toggle theme state to Dashboard
  • Append Toggle Button to Dashboard / AppBar to change theme state

Is this similar to what you've had in mind?

@shravan20
Copy link
Owner Author

Hi @koskrit ,

Thank you for your time!
Yes, we were looking for something similar to what you proposed. Feel free to implement your ideology and raise a PR.

Looking forward to see your PR.

@koskrit
Copy link
Contributor
koskrit commented Apr 23, 2021 •
edited by shravan20
Loading

Update1:

  • Added ThemeProvider at Dashboard
  • Added toggle theme state
  • Added Toggle Button to Dashboard / AppBar to change theme state
  • Tested Theme functionality with sample themes
  • Create Github Dark Theme with JSS

@shravan20
Copy link
Owner Author
shravan20 commented Apr 23, 2021 •
edited
Loading

@koskrit Raise a PR, review the code and let you know the status.

@koskrit
Copy link
Contributor
koskrit commented Apr 24, 2021 •
edited by shravan20
Loading

Before I do some cleanup and submit the PR, maybe you could give me some thoughts on the first draft.

Update2:

  • Create Github Dark Theme with JSS

Theme Draft1

ddf

All colors are taken from the Github color palette

Any reflections or preferences for the color choices?

@shravan20
Copy link
Owner Author

Hi @koskrit
I believe the colour choices for the dark mode looks good for now. Inverted duo is fine for now!

@shravan20 shravan20 added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 24, 2021
@shravan20 shravan20 linked a pull request Apr 25, 2021 that will close this issue
#120 Adds custom Theming Functionality, and Dark Theme toggle Logic. #121
Merged
shravan20 pushed a commit that referenced this issue Apr 25, 2021
@koskrit
#120 Adds custom Theming Functionality, and Dark Theme toggle Logic. (#…
054f554 
…121)

* Adds Theming functionality
* Fixes React.strict bugs
* Initiates Dark/Light Global themes
* Edits ThemeIcon Styles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed Medium work This task takes little time to complete. (ETA week or two)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#120 Adds custom Theming Functionality, and Dark Theme toggle Logic. koskrit/github-readme-quotes
2 participants
@shravan20 @koskrit
0