fix: code diff display in dropdown-menu documentation #5926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@terrence-ou is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
While reading the documentation for the Dropdown Menu component, I noticed some syntax highlighting issues in the changelog section that might be a bit confusing :
The code blocks in the section are visually inconsistent. One block is missing the “+” sign to emphasize the added code, another block uses
tsxsyntax highlighting, which doesn’t align with the purpose of the section that suggests developers to add additional tailwind styles.To address these issues, I made the following changes:
diffsyntax highlighting for code display consistency.cvareference in the second paragraph of the 2024-10-25... changelog withcn. Thecvafunction seems not used in the associated code block, but cn is.Please refer to the following screenshots for the changes I made on the doc, with left one is before change, and the right one is after change:
Thanks for considering my PR, and please let me know if you have any feedback or additional suggestions!