EGP 39 #7
Open
EGP 39 #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalextowle
reviewed
Feb 25, 2025
| const treasuryInterface = new ethers.utils.Interface(Treasury__factory.abi); | ||
| console.log("hdTokenAddress", hdTokenAddress); | ||
| console.log("hdLockingVaultAddress", hdLockingVaultAddress); | ||
| const callDataTreasuryApproveHdLockingVault = |
There was a problem hiding this comment.
We don't need to approve the locking vault or the GSC vault. We only need to approve the migration vaults because those are the vaults that have to pull HD from the treasury.
jalextowle
reviewed
Feb 25, 2025
| ERC20PermitWithMint__factory.abi | ||
| ); | ||
|
|
||
| const callDataMintDelvBalance = hdTokenInterface.encodeFunctionData("mint", [ |
There was a problem hiding this comment.
Rather than minting, we should just use the initial allocation of tokens.
The flow that I'm envisioning is:
- Deploy the HD token.
- Send HD tokens to the treasury.
- The treasury approves the migration vault.
- The treasury burns the ELFI tokens from DELV, the foundation, and the treasury.
- The treasury transfers HD to DELV and the foundation (note, not to itself because it already has it) to compensate them for the burned ELFI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a larger proposal that includes the following:
remove vaults from CoreVoting
remove gscVault from gscCoreVoting
add vaults to CoreVoting
add vaults to gscCoreVoting
set approvals for vaults from the treasury for HD tokens
burn balances for Delv, Foundation, Treasury
mint 10x balances for Delv, Foundation, Treasury
revoke owner privileges for the ELFI token