8000 Remove deprecated label type from queries by dkeden · Pull Request #157 · seermedical/seer-py · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove deprecated label type from queries #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 30, 2023
Merged

Remove deprecated label type from queries #157

merged 3 commits into master from
May 30, 2023

Conversation

dkeden
Copy link
Contributor
@dkeden dkeden commented Dec 9, 2022 •
edited
Loading

This PR removes labelType from studies queries as it seems to have been deprecated.

This causes issues for this still using public scripts to download MSG data.

Link to issue: #156 (comment)

@dkeden dkeden linked an issue Dec 9, 2022 that may be closed by this pull request
msg data downloader not working #156
Open
norrishd
norrishd approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor
@norrishd norrishd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested this or checked you've caught every single place labelGroup.labelType is used, but I trust your ctrl-C/ctrl-F skillz and LGTM!

ronrest
ronrest approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor
@ronrest ronrest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@dkeden dkeden merged commit 58d7ce5 into master May 30, 2023
@dkeden dkeden deleted the remove-deprecated-labelType-from-queries branch May 30, 2023 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norrishd norrishd norrishd approved these changes

@ronrest ronrest ronrest approved these changes

@EwanNurse EwanNurse Awaiting requested review from EwanNurse

@ryanmseer ryanmseer Awaiting requested review from ryanmseer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

msg data downloader not working
3 participants
@dkeden @norrishd @ronrest
0