feat(unpack,metrics): remove node-fe 8000 tch polyfill and blob-to-buffer, … #226
Conversation
…added tests, BREAKING-CHANGE
🦋 Changeset detectedLatest commit: fb25866 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thanks for this. I like the direction and will look at getting this in this week sometime. Ta |
| const fontPath = join(__dirname, './__fixtures__/NotoSans-Regular.ttf'); | ||
| const font = await readFile(fontPath); | ||
| const metrics = await fromBuffer(font); | ||
| expect(metrics).toMatchSnapshot(); |
There was a problem hiding this comment.
Given the expectation is the same across all tests (return the same metrics object), i would suggest not using snapshots here. Instead, I recommend creating an expectedMetrics object locally in this file and assert that what is returned from the different methods matches it.
packages/unpack/package.json
Outdated
There was a problem hiding this comment.
Can you add an engines config that specifies the requirement of >=18.
|
I just made suggested changes. |
This is the last dependency in my project that pulls node-fetch.
Removed node-fetch polyfill and blob-to-buffer.
This is a breaking change, and it would require node >= 18. If you want this, this should be released as major version