-
Notifications
You must be signed in to change notification settings - Fork 1
Improve remote chapter #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to give context why branches are needed
This allows to give motivation to why protocols are required
randombenj
reviewed
Mar 18, 2022
timofurrer
requested changes
Mar 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Open points: - diagrams are kinda small - make target multi-digram runs on everybuild - extract slides from svg by script and build all slides automaticaly
7f4da02
to
f0b42f3
Compare
Thanks for your feedback GitWorkshop_Handout_2022-03-19.pdf |
if there is no more feedback i will merge this today |
randombenj
approved these changes
Mar 21, 2022
timofurrer
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Next iteration of the remote chapter! ✨
Please take a look and give feedback. Look out for typos!
Slides which are in the wrong order or any other issues.
Also if you have a better idea how to handle the
multi-diagram
(one svg multiple exported images) let me know.GitWorkshop_Handout_2022-03-18.pdf
GitWorkshop_Slides_2022-03-18.pdf