feat: add support for custom patches #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for custom patches by moving them to a new directory structure and ensuring that using a custom patch via "snapfu patch apply [custom-patch-name]" does not affect package.json version.
- New function getCustomPatchVersions to load custom patch versions.
- Updated applyPatches logic to distinguish custom patches from standard version patches.
- Conditional update of package.json is applied only for standard patches.
Comments suppressed due to low confidence (1)
src/patch.js:156
- The regex contains a double caret (^^) which is likely unintended and may prevent correct matching of version strings. Consider replacing it with a single caret '^'.
const versionMatch = /^^\w?(\d+\.\d+\.\d+)$/.exec(versionApply);
Closed
korgon
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved custom patches to a different directory
~/.searchspring/snapfu-patches/custom/{version}instead of~/.searchspring/snapfu-patches/{framework}/{version}so that existing versions of snapfu don't break when reading new snapfu-patches structure. Custom patches are not listed in thesnapfu patch listcommand.snapfu patch apply [version]andsnapfu patch apply latestshould not be affected. Only specifying a custom patch viasnapfu patch apply [custom-patch-name]should be allowed and also not alter package.json version.