Allow for populating note body when note is defined in frontmatter #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanlowe
requested changes
Jun 6, 2024
There was a problem hiding this comment.
Hey, looks good overall. Just a few notes and then we can get this merged in.
- Small mishap on
events.ts - Please write some "release notes" in the README regarding this change (release for this will be 2.1.11) and move the current release notes to the changelog.
- After doing that, run
npm run bump:patchto update the version numbers on everything (manifest.json, package.json, & package-lock.json) - This is a particularity of mine but please alphabetize
noteBodywith the othernote..variables/keys - I actually recently deleted the description attribute from the "Insert HTML event" function
createTimelineEventInCurrentNoteso you'll want to add that back intocommands.ts:newEventElement.setAttribute( 'data-description', '' ) - and lastly, if you want (optional here - I can do it later), you can add a small section on the Description attribute to the docs in the
01_html_arguments.mdfile.
Thanks!
…a frontmatter by way of the 'description' property - edited style rules so that whitespace within the description property (line breaks, esp.) is respected and not discarded - reinstated the 'description' property for HTML defined events (albeit redundant) - updated documentation to reflect changes
I actually hadn't ran npm run bump:patch yet because I wanted to build the plugin and test it and make sure it worked as intended first but getting the build script to run proved difficult for me |
|
If you would open another issue for tracking down the build issues, I believe that would be extremely helpful for anyone who may want to contribute in the future. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only notes defined via HTML had their body populated via the
innerText. These edits should allow for the frontmatterdescriptionproperty to achieve the same effect.