Lp shade swap #213
Merged
Lp shade swap #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e020d46 to
f5ed77c
Compare
…reasury_manager.holders
|
'contract-harness' is already fixed and working nicely with make in the latest 'dev' branch so you can revert those changes. Reverting the changes should also make your checks pass since they seem to be related to that. |
FloppyDisck
suggested changes
Jun 17, 2022
FloppyDisck
approved these changes
Jun 21, 2022
| @@ -91,7 +91,10 @@ pub fn allowance<S: Storage, A: Api, Q: Querier>( | |||
| owner: HumanAddr, | |||
| spender: HumanAddr, | |||
| ) -> StdResult<QueryAnswer> { | |||
| let allowance = Allowance::load(&deps.storage, (owner.clone(), spender.clone()))?; | |||
There was a problem hiding this comment.
could you revert this and then pull from dev? This change is already merged
There was a problem hiding this comment.
It is adding in the may_load, not sure why its showing as my change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a little bit of treasury stuff, added some contract harnesses, Also got a shell contract for shadeswap LP providing but waiting on a merge into dev from shadeswap for the in progress AMM contract.