Make format command #153
Make format command #153
Conversation
makefile
Outdated
|
|
||
| format: | ||
| cargo fmt | ||
| cargo fix --allow-dirty --allow-staged |
There was a problem hiding this comment.
Not 100% sure about --allow-dirty --allow-staged flags, they seem useful to run before committing (this is how I usually use go fmt),
could these break my code in unexpected ways ?
There was a problem hiding this comment.
Does that basically mean that it will perform formatting on staged changes as well as unstaged changes (dirty)?
There was a problem hiding this comment.
Just a suggestion but I'd keep the format task just to formatting.
With cargo fix its generally good practice to do this within its own commit so the changes can be easily rolled back if they break something.
There was a problem hiding this comment.
Have read some more about cargo fix, you are right,
since it does more than simple code formatting it is better to run it separately from make format, removed it (leaving it up to developer to apply, if he wishes)
05ab03b to
2f08b41
Compare
This PR:
make formatto apply a common set of formatting rules across all Shade repo (along withrustfmt.tomlconfiguration file for it)