Review of user manual (only typos and syntax) #1255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The commits should probably be squashed into a single commit when we merge, no need for one per file. |
|
Regarding a squashed merge, I agree. Will have to investigate that first. |
axel-h
reviewed
May 27, 2024
axel-h
reviewed
May 27, 2024
axel-h
reviewed
May 27, 2024
All good, you don't have to do anything for that, there is a "Squash and merge" option we can use on GitHub for it. |
|
I finished the review now (see Review part2). |
bbrcknl
reviewed
May 28, 2024
hexcoder-
commented
May 31, 2024
lsf37
reviewed
Jun 16, 2024
lsf37
reviewed
Jun 16, 2024
Co-authored-by: Gerwin Klein <gerwin.klein@proofcraft.systems> Signed-off-by: hexcoder <heiko@hexco.de> Signed-off-by: Gerwin Klein <gerwin.klein@proofcraft.systems>
lsf37
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I reviewed the user manual up to before section 10.7 (part 1) with regard to typos and consistency. Since I am neither a native speaker nor an expert, please review my changes, thanks.