SCUMM: Initial work on the PowerPC version of Fate of Atlantis #6623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should presumably use the V6 GUI instead of V5, but there are some differences. Unfortunately I don't own this version myself, so this may be as far as I get.
cc8fbf8 to
1af5fec
Compare
added 14 commits
May 18, 2025 10:02
I don't know if the music player is like Day of the Tentacle, Sam & Max, or someting entirely different. But this should allow it to proceed for now.
Judging by screenshots, the borders are even misaligned in the same way, so this should work.
This game doesn't have a menu item for Effects, so adjust the id of the clicked item to pretend that it does.
I've also moved the code to read a CURS cursor to macgui_impl.cpp, so that it can be shared between all the classes that use it.
Also, use that flag to detect if it's a game that blacks out the screen or not.
The About menu for Fate of Atlantis should now show the correct name, and the options dialog should apply the correct settings.
It's apparently not a Mac resource, as I had first surmised. In fact, it may be the same as the DOS version, except not animated and high resolution.
Calling updateCursor() where I did it crashed ScummVM. Calling it later broke cursors in other Mac games. Third option: Use a Mac Window Manager custom cursor instead, the same as Indy 3. This should just work.
This should hopefully fix the Music menu item for Fate of Atlantis PPC too.
We don't really want to check which versin of the game is running, we want to check if it's an Aaron Giles port or not. This should fix the default size of Fate of Atlantis PowerPC's dialog windows.
Note that _isModernMacVersion also covers Maniac Mansion, but I don't think that's going to be a problem.
|
I have merged this. I still don't have the game, but based on lman's feedback it should be working on par with the other Aaron Giles ports now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on information I've received from lman via Discord.
The LucasArts Archive vol 1 for the Mac apparently contains both the older version of Fate of Atlantis, and a newer one in the same folder. The old version would be these files:
While this would be the newer version:
ScummVM already detects the newer version, but does not recognize the executable by name.
What I think needs to be done:
MacGuiV6instead ofMacGuiV5. The presence of anMBARresource should be a good enough heuristic. [Done]Unfortunately those LucasArts archives are not cheap, and I got outbid in my last attempt, which is why I can't test this myself.