8000 Henrikth93 data contracts issue#18 by henrikth93 · Pull Request #27 · scribe-org/Scribe-Server · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Henrikth93 data contracts issue#18 #27

New issue 8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Henrikth93 data contracts issue#18 #27

wants to merge 3 commits into from

Conversation

henrikth93
Copy link
Member

Contributor checklist

Description

Related issue

@henrikth93
Add route to download data contracts
955e4f9 
This commit will add a route for downloading data contracts.
@henrikth93
Cange comment
a9de5b7 
This will change a comment in the code so it says "iso" instead of "lang".
@github-actions GitHub Actions
Copy link
github-actions bot commented Mar 9, 2025

Thank you for the pull request! ❤️

The Scribe-Server team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

@github-actions GitHub Actions
Copy link
github-actions bot commented Mar 9, 2025

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@henrikth93 henrikth93 requested a review from andrewtavis March 9, 2025 21:07
@henrikth93
Copy link
Member Author

I see the lint check failed, gonna fix that.

@henrikth93
Add license header
d56cc86 
This commit wil ladd the license header
@henrikth93 henrikth93 requested a review from wkyoshida March 11, 2025 19:23
@axif0
Copy link
Member
axif0 commented Mar 14, 2025

Do we have a plan to move the data-contract in the mariaDB also?

cc: @andrewtavis, @wkyoshida

@andrewtavis
Copy link
Member < 8000 /div>

To me they don't need to be as we can just send the JSON, but open to suggestions :)

@axif0
Copy link
Member
axif0 commented Jun 24, 2025

I think we need to consider this PR also. As @henrikth93 used OpenAPI for data-contracts.

CC: @DeleMike

@andrewtavis
Copy link
Member

100%, and thanks for your attention here, @axif0! What steps would be needed to get this in line with the work from #23? The contracts themselves are not important as we'll need to finalize those based on Scribe-Android, but the rest of the code should be consistent with what was just merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewtavis andrewtavis Awaiting requested review from andrewtavis

@wkyoshida wkyoshida Awaiting requested review from wkyoshida

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@henrikth93 @axif0 @andrewtavis
0