-
Notifications
You must be signed in to change notification settings - Fork 66
Fix dangling top-level kdoc comments #390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for the pull request! ❤️The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
@Femimat Could the conflicts be fixed ? |
Okay @angrezichatterbox, I'll check it out. |
Hi @angrezichatterbox, I’ve fixed the issue. You can review the PR now—thanks! |
I would look into it later today :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me @Femimat. Its good for a merge :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me as well, @Femimat :) Appreciate your continued work on these issues!
* fix: Fix dangling top-level kdoc comments (#390) * Minor edits to docstrings and spacing --------- Co-authored-by: Andrew Tavis McAllister <andrew.t.mcallister@gmail.com>
Contributor checklist
./gradlew lintKotlin detekt test
command as directed in the testing section of the contributing guideDescription
This pull request fixes dangling top-level KDoc comments.
Related issue