Fix typo in cmdline.py comment: 'a argument' -> 'an argument' #6875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gallaecio
reviewed
Jun 7, 2025
Gallaecio
reviewed
Jun 7, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #6875 +/- ##
==========================================
+ Coverage 90.88% 90.91% +0.03%
==========================================
Files 165 165
Lines 12580 12649 +69
Branches 1642 1662 +20
==========================================
+ Hits 11433 11500 +67
- Misses 836 837 +1
- Partials 311 312 +1
|
I've written a test for the _parse_optional method. Please feel free to use it if it's helpful, or ignore it if it's not suitable.
|
Could you revert d66f649? I don’t think we need tests for this change. |
|
Reverted the test commit as requested. Thank you for the review! |
Gallaecio
approved these changes
Jun 8, 2025
|
Hmm… Those failures are completely unrelated. I wonder what’s triggering them, though. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request fixes a minor typo in a comment in scrapy/cmdline.py:
Changes "a argument" to "an argument" for correct English usage.
Also improves the comment's clarity by changing "that is" to "that it is" for better English grammar.
No code logic or functionality is affected by this change.
Checklist:
[x] My change is as small as possible and focused on a single issue (typo fix).
[x] No tests are needed as this is a comment-only change.
[x] I have followed the contribution guidelines.