8000 refactor: remove deprecated grpc api usage by romshark · Pull Request #4772 · scionproto/scion · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: remove deprecated grpc api usage #4772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

romshark
Copy link
Contributor

This is a sub-task of #4769

@romshark romshark requested a review from a team May 16, 2025 13:23
@romshark romshark self-assigned this May 16, 2025
@jiceatscion
Copy link
Contributor

This change is Reviewable

Copy link
Contributor
@katyatitkova katyatitkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @romshark)

@romshark
Copy link
Contributor Author

As explained in 2d1f66d I will close this as a won't fix.

@romshark romshark closed this May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0