router: afpacket udp underlay (WIP) #4763
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Added another filter. Needed to ensure that the kernel does not do any processing on the packets received by the raw socket. Expensive stuff would otherwise result (e.g. icmp responses).
Also ditched the PacketSource and Packets() channel. It's too buggy even for us in tests (crashes after closing the afp). Added draining for afp once filter is set. Else we get stray packets, which confuses the test. Did the same in the afp undelay.
<
8000
a href="/scionproto/scion/pull/4763/commits/bb0c07ee525016b058979ab2bf51f838e11ff3ad" class="Link--secondary">bb0c07e
Comments, debug stmt and useless error return.
Now passes the benchmark.
Not quite sure what difference it makes, but it sure isn't an sh_test.
In passing added some facility for short debug runs.
This is a feable attempt at making it at least slightly faster than the router.
We used to require more than 3% packet drop. We are now content with 3% or more.
Had to rearrange the code a tiny bit. In passing, attempting to add the needed capabilities to the router in integration tests besides the router benchmark.
In passing. Fixed another missing space in router_multi test script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the afpudpip underlay is interchangeable with the udpip underlay but uses af_packet sockets instead of udp sockets. The only expected difference is performance. As a result, both afpudpip and udpip underlays register themselves with the name "udpip". There is now a precedence field that allows afpudpip, when available, to supercede udpip.