8000 Enable backbeatRoute tests & associated fixes by francoisferrand · Pull Request #5801 · scality/cloudserver · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Enable backbeatRoute tests & associated fixes #5801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 16, 2025
Merged

Enable backbeatRoute tests & associated fixes #5801

merged 8 commits into from
May 16, 2025

Conversation

francoisferrand
Copy link
Contributor
  • Fix missing bit in routeBackbeat test after cherry-pick to branch 8
  • Unskip 'backbeat PUT routes' tests
  • Catch error in veeam route tests
  • Update azure sdk in multibackend tests
  • Ensure we always respect versioning status
  • Fix double response on conditional batchDelete
  • Disable some backbeat routes with Ceph

Issue: CLDSRV-394

@bert-e
Copy link
Contributor
bert-e commented May 15, 2025

Hello francoisferrand,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval ⭐
/bypass_build_status Bypass the build and test status ⭐
/bypass_commit_size Bypass the check on the size of the changeset TBA ⭐
/bypass_incompatible_branch Bypass the check on the source branch prefix ⭐
/bypass_jira_check Bypass the Jira issue check ⭐
/bypass_peer_approval Bypass the pull request peers' approval ⭐
/bypass_leader_approval Bypass the pull request leaders' approval ⭐
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@codecov Codecov
Copy link
codecov bot commented May 15, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.65%. Comparing base (477744a) to head (52998ba).
Report is 8 commits behind head on development/9.0.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
lib/routes/routeBackbeat.js 75.00% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (75.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
lib/routes/routeBackbeat.js 70.63% <75.00%> (+25.56%) ⬆️

... and 3 files with indirect coverage changes

@@                 Coverage Diff                 @@
##           development/9.0    #5801      +/-   ##
===================================================
+ Coverage            74.01%   75.65%   +1.63%     
===================================================
  Files                  188      188              
  Lines                11946    11944       -2     
===================================================
+ Hits                  8842     9036     +194     
+ Misses                3104     2908     -196
Flag Coverage Δ
ceph-backend-test 46.88% <25.00%> (+2.64%) ⬆️
file-ft-tests 47.26% <25.00%> (-0.01%) ⬇️
kmip-ft-tests 26.72% <0.00%> (+<0.01%) ⬆️
mongo-v0-ft-tests 47.69% <25.00%> (-0.01%) ⬇️
mongo-v1-ft-tests 47.71% <25.00%> (-0.01%) ⬇️
multiple-backend 35.40% <75.00%> (+3.29%) ⬆️
quota-tests 32.13% <0.00%> (-0.87%) ⬇️
quota-tests-inflights 34.11% <0.00%> (-0.01%) ⬇️
unit 65.66% <25.00%> (-0.01%) ⬇️
utapi-v2-tests 33.23% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bert-e
Copy link
Contributor
bert-e commented May 15, 2025

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@francoisferrand
Copy link
Contributor Author

/create_integration_branches

@scality scality deleted a comment from bert-e May 16, 2025
jonathan-gramain and others added 8 commits May 16, 2025 13:45
@jonathan-gramain @francoisferrand
fix missing bit in routeBackbeat test after cherry-pick to branch 8
31cf395 
Original cherry-pick done in CLDSRV-543

Issue: CLDSRV-394
@jonathan-gramain @francoisferrand
unskip 'backbeat PUT routes' tests
fddb7aa 
Issue: CLDSRV-394
@francoisferrand
Catch error in veeam route tests
c93751a 
Issue: CLDSRV-394
@francoisferrand
Update azure sdk in multibackend tests
826e26a 
Issue: CLDSRV-394
@francoisferrand
Ensure we always respect versioning status
7d731a3 
Revert 7e405ff, as it prevents creating
new versions in versioned buckets when not specifying versionId. The
proper fix was introduced later in [2]

[1] #4655
[2] #5167

Issue: CLDSRV-394
@francoisferrand
Fix double response on conditional batchDelete
7dac6ce 
Issue: CLDSRV-394
@francoisferrand
Disable some backbeat routes with Ceph
0a5d7b5 
The tests do not pass, leaving them disabled for now: this should be
handled in a followup ticket.

Issue: CLDSRV-394
@francoisferrand
Fix itSkipCeph to skip only with Ceph
52998ba 
Issue: CLDSRV-394
@scality scality deleted a comment from bert-e May 16, 2025
@francoisferrand
Copy link
Contributor Author

/approve

@scality scality deleted a comment from bert-e May 16, 2025
@scality scality deleted a comment from bert-e May 16, 2025
@bert-e bert-e merged commit 52998ba into development/9.0 May 16, 2025
18 of 19 checks passed
@bert-e
Copy link
Contributor
bert-e commented May 16, 2025

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/9.0

  • ✔️ development/9.1

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.8

Please check the status of the associated issue CLDSRV-394.

Goodbye francoisferrand.

The following options are set: approve, create_integration_branches

@bert-e bert-e deleted the bugfix/CLDSRV-394 branch May 16, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-gramain jonathan-gramain jonathan-gramain approved these changes

@williamlardier williamlardier williamlardier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@francoisferrand @bert-e @jonathan-gramain @williamlardier
0