8000 Move context functions to MockContext by steinybot · Pull Request #632 · scalamock/scalamock · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Move context functions to MockContext #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2025
Merged

Move context functions to MockContext #632

merged 1 commit into from
May 18, 2025

Conversation

steinybot
Copy link
Contributor

Pull Request Checklist

  • I agree to licence my contributions under the MIT licence
  • I have added copyright headers to new files
  • I have added tests for any changed functionality

Fixes

Fixes #627

Purpose

This adds all the inContext variations such as inAnyOrder and inSequence to AsyncMockFactoryBase.

Background Context

I put these into MockContext as they apply to anything that has a context. They are independent of whether the test is synchronous or asynchronous. Implementations of withExpectations already take this into account.

References

Are there any relevant issues / PRs / mailing lists discussions?

@steinybot steinybot force-pushed the async-mock-orderings branch from c22dae4 to 3201633 Compare April 23, 2025 23:36
@steinybot steinybot force-pushed the async-mock-orderings branch from 3201633 to 6037ad9 Compare April 23, 2025 23:37
@steinybot steinybot mentioned this pull request Apr 23, 2025
Closed
@goshacodes goshacodes added this to the 7.3.2 milestone Apr 29, 2025
goshacodes
goshacodes requested changes Apr 29, 2025
View reviewed changes
@goshacodes goshacodes modified the milestones: 7.3.2, 7.3.3 Apr 30, 2025
@goshacodes
Copy link
Collaborator
goshacodes commented May 4, 2025 •
edited
Loading

If you have no time - I'll do it soon myself.
And thank you for your contribution!

@goshacodes
Copy link
Collaborator
goshacodes commented May 18, 2025 •
edited
Loading

Looked at your PR once more, looks like it was totally fine in the first place :)

@goshacodes goshacodes merged commit ccef722 into scalamock:series/7.x May 18, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goshacodes goshacodes goshacodes approved these changes

Assignees
No one assigned
Labels 4DED
None yet
Projects
None yet
Milestone
7.3.3
Development

Successfully merging this pull request may close these issues.

AsyncMockFactoryBase is missing ordering methods
2 participants
@steinybot @goshacodes
0