8000 Add header functionality by vincentdehaan · Pull Request #137 · scala-tsi/scala-tsi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add header functionality #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 28, 2021
Merged

Add header functionality #137

merged 4 commits into from
Feb 28, 2021

Conversation

vincentdehaan
Copy link
Contributor

This PR allows for adding a header to the generated declaration file. This can either be a comment or a custom declaration.

@dhoepelman dhoepelman added the enhancement New features or additional supported types label Feb 21, 2021
@dhoepelman
Copy link
Member

Thank you for the contribution Vincent.
This is useful and I'm even considering setting it to "DO NOT EDIT: generated file by scala-tsi" by default.

The PR is missing a test, this can be added in plugin/src/sbt-test/ScalaTsiPlugin/.
Or the /example project can be modified to include it

@vincentdehaan
Copy link
Contributor Author

Thanks. I set the default message and updated the test.

@dhoepelman dhoepelman merged commit afa3d11 into scala-tsi:master Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New features or additional supported types
Projects
None yet
< 3FD2 !-- -->
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincentdehaan @dhoepelman
0