[1.x] Shortcut sbtn shutdown #8057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Problem** WHen portfile is not found, sbtn will try to start the server even when the desired command is shutdown. **Solution** When the command is just shutdown, don't start the server.
adpi2
approved these changes
Mar 5, 2025
NthPortal
approved these changes
Mar 5, 2025
no-a sbt server is a-running! ciao! 🇮🇹 |
|
what causes this to make it to coursier? |
|
Not sure what Coursier uses to index sbtn, but next time I publish sbt 1.x, I'll build sbtn together. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions can
2C90
not be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8055
Problem
WHen portfile is not found, sbtn will try to start the server even when the desired command is shutdown.
Solution
When the command is just shutdown, don't start the server.