8000 Use binary compiler bridge by eed3si9n · Pull Request #7374 · sbt/sbt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use binary compiler bridge #7374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2023
Merged

Use binary compiler bridge #7374

merged 1 commit into from
Sep 12, 2023
+43 −31

Conversation

eed3si9n
Copy link
Member
@eed3si9n eed3si9n commented Sep 12, 2023 •
edited
Loading

Problem

Starting Scala 2.13.12, Scala 2 has in-sourced the compiler bridge imple (scala/scala#10472), which hopefully will be kept up to date more than the ones in Zinc.

Solution

This switches to using the pre-compiled compiler bridge for >=2.13.12 /cc @lrytz

@eed3si9n
Use binary compiler bridge
b1e9308 
Problem
-------
Starting Scala 2.13.12, Scala 2 has in-sourced the compiler bridge
implementtion, which hopefully will be kept up to date more than the
ones in Zinc.

Solution
--------
This switches to using the pre-compiled compiler bridge for >=2.13.12.
lrytz
lrytz approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor
@lrytz lrytz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! I didn't build and test it though.

Greetings from the summit in Madrid :)

ts

@eed3si9n eed3si9n merged commit 8b15b44 into sbt:1.9.x Sep 12, 2023
@eed3si9n eed3si9n deleted the wip/bridge branch September 12, 2023 14:56
@eed3si9n eed3si9n modified the milestones: 1.10.0, 1.9.5 Sep 13, 2023
@He-Pin
Copy link
He-Pin commented Sep 14, 2023 •
edited
Loading

I still saw:

[info] Non-compiled module 'compiler-bridge_2.12' for Scala 2.12.18. Compiling...
[info]   Compilation completed in 11.463s.

Will this land in scala 2.12.18+?

@SethTisue
Copy link
Member

Will this land in scala 2.12.18+?

It won't. For Scala versions older than 2.13.12, everything will keep on working the way it used to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrytz lrytz lrytz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9.5
Development

Successfully merging this pull request may close these issues.
4 participants
@eed3si9n @He-Pin @SethTisue @lrytz
0