[1.8.x] Fixes M1 support #7121
Merged
[1.8.x] Fixes M1 support #7121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes sbt#7117 Problem ------- sbt no longer works on a Mac with M1 (aarch64) chips because it fails on ipcsocket library, which we maintain. This was caused by architecture detection that was added in 1.6.1, which did not take in account for macOS universal binary. Solution -------- Update to ipcsocket 1.6.2.
mkurz
approved these changes
Jan 4, 2023
mkurz
reviewed
Jan 4, 2023
| @@ -26,7 +26,7 @@ object Dependencies { | |||
| val launcherInterface = "org.scala-sbt" % "launcher-interface" % launcherVersion | |||
| val rawLauncher = "org.scala-sbt" % "launcher" % launcherVersion | |||
| val testInterface = "org.scala-sbt" % "test-interface" % "1.0" | |||
| val ipcSocket = "org.scala-sbt.ipcsocket" % "ipcsocket" % "1.6.1" | |||
| val ipcSocket = "org.scala-sbt.ipcsocket" % "ipcsocket" % "1.6.2" | |||
There was a problem hiding this comment.
No tag yet? https://github.com/sbt/ipcsocket/tags
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #7120
Fixes #7117
Problem
sbt no longer works on a Mac with M1 (aarch64) chips because it fails on ipcsocket library, which we maintain.
This was caused by architecture detection that was added in 1.6.1, which did not take in account for macOS universal binary.
Solution
Update to ipcsocket 1.6.2.