8000 [#6631] Enable launcher script use --sbt-boot by er1c · Pull Request #6632 · sbt/sbt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[#6631] Enable launcher script use --sbt-boot #6632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
8000
Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

[#6631] Enable launcher script use --sbt-boot #6632

wants to merge 3 commits into from
+74 −33

Conversation

er1c
Copy link
Contributor
@er1c er1c commented Aug 21, 2021

This addresses #6631 to use --sbt-boot directory to download sbt-launch.jar or sbtn

Also added some minor SbtScriptTest output cleanup.

@er1c
Copy link
Contributor Author
er1c commented Aug 21, 2021

Looks like I broke --sbt-jar ooops

@er1c er1c force-pushed the runner-script-sbt-boot branch from 85ef0ca to b7e03c4 Compare August 21, 2021 19:52
er1c
er1c commented Aug 21, 2021
View reviewed changes
sbt Outdated
@@ -620,7 +644,6 @@ map_args () {
-no-share|--no-share) options=( "${options[@]}" "${noshare_opts[@]}" ) && shift ;;
-no-global|--no-global) options=( "${options[@]}" "-Dsbt.global.base=$(pwd)/project/.sbtboot" ) && shift ;;
-ivy|--ivy) require_arg path "$1" "$2" && options=( "${options[@]}" "-Dsbt.ivy.home=$2" ) && shift 2 ;;
-sbt-boot|--sbt-boot) require_arg path "$1" "$2" && options=( "${options[@]}" "-Dsbt.boot.directory=$2" ) && shift 2 ;;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not quite sure what the difference between map_args and process_args is, but trying to set the sbt_boot var here didn't work for some reason

@er1c er1c force-pushed the runner-script-sbt-boot branch 3 times, most recently from 3a17541 to a3945a2 Compare August 21, 2021 22:21
@er1c er1c force-pushed the runner-script-sbt-boot branch from a3945a2 to d001588 Compare September 3, 2021 03:15
@er1c er1c force-pushed the runner-script-sbt-boot branch from d001588 to 12eb3d4 Compare September 3, 2021 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@er1c
0