Add support for custom protocol with coursier #6375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 9, 2021
11c1408 to
2f855d2
Compare
2f855d2 to
5ffc6bc
Compare
|
Is there anything that speaks against this? I'd really like to have this 🙂 |
|
What is blocking this? It would be of great help for us. |
|
⬆️ 🙏 |
|
I think this PR should be on top of 1.9.x branch, since develop branch is for sbt 2.x. |
|
It seems to be possible to set it via csrConfiguration := csrConfiguration.value.withProtocolHandlerDependencies(
Seq("org.example" % "google-artifact-repository-coursier" % "0.1.0")
) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In coursier, you can handle custom protocols by defining a protocol handler:
https://get-coursier.io/docs/2.0.10/extra.html#extra-protocols
https://github.com/coursier/coursier/blob/ce251d0288bf029e4eeb8700e8990178559a005d/modules/tests/jvm/src/test/scala/coursier/cache/protocol/TestprotocolHandler.scala
I'm currently implementing support for Google Artifact Resitory:
coursier/coursier#1987 (comment)
When dealing with artifact with protocol
artifactregistryI need to have a plugin available in the classpath. Since lmcoursier is in the sbt launcher classpath, it's not available by addinglibraryDependencies += ...inproject/plugins.sbtlike you would do for an sbt plugin. Therefore, I propose a way to explicitly declare the artifacts you need to handle the protocol handling.Users of custom protocol can now specify dependencies to their handler via this sbt setting:
Depends on coursier/sbt-coursier#327