Reduce 'module not found' console logging #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many users will only have the ability to resolve module 'firebase' or 'firebase-admin' but not necessarily both. Impacted users see repeated logging of 'Module not found, mocking skipped' messages which can cause concern, and also pollute the logs of larger test suites with many such lines. This change only logs to console in the more severe case where neither module can be found.
sbatson5
approved these changes
Nov 13, 2024
|
@sbatson5 thanks for the approval, I have no write access so you will need to merge pls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many users will only have the ability to resolve module 'firebase' or 'firebase-admin' but not necessarily both.
Impacted users see repeated logging of 'Module not found, mocking skipped' messages which can cause concern, and also pollute the logs of larger test suites with many such lines.
This change only logs to console in the more severe case where neither module can be found.
Description
Related issues
How to test