feat: save&overwrite client hello #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saucesteals
requested changes
Jun 16, 2024
| return | ||
| } | ||
| clientHello = ch | ||
| fmt.Println("overwrote client hello UwU") |
| return | ||
| } | ||
| ctx.Logf("Wrote client hello to %s", clientHelloPath) | ||
| fmt.Printf("Wrote client hello to %s\n", clientHelloPath) |
| clientHello = ch | ||
| } | ||
|
|
||
| ts := strconv.FormatInt(time.Now().UnixMilli(), 10) |
There was a problem hiding this comment.
This doesn't seem reliable. Let's use the host from the CONNECT as the filename instead
There was a problem hiding this comment.
also could be a good idea to guard the folder (each file) with a mutex but not a big deal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows saving and overwriting the Client Hello through the following environment variables:
GOPROXY_CLIENT_HELLO_SAVE_DIRGOPROXY_OVERWRITE_CLIENT_HELLOFor more information on this PR, see: saucesteals/utlsproxy#6