[Attr Types] Add proposal #4031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goodwine
approved these changes
Feb 13, 2025
accepted/attr-type.md
Outdated
| [The `<attr-unit>` production]: https://drafts.csswg.org/css-values-5/#typedef-attr-unit | ||
|
|
||
| This is further complicated by the fact that the `attr()` function in which the | ||
| `<attr-type>` production appears has been supported in browsers for a number of |
There was a problem hiding this comment.
I find reading "appears has been supported" a little bit odd because it kinda reads very similar to "appears to have been supported", but IIUC the "appears" verb is for the "production" subject 🤔
Can you reword this slightly to avoid that possible confusion?
There was a problem hiding this comment.
Added parentheses to clarify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4030