8000 Viya JES approach workaround, job arguments are case-sensitive and webout was not returned by medjedovicm · Pull Request #845 · sasjs/adapter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Viya JES approach workaround, job arguments are case-sensitive and webout was not returned #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2025
Merged

Viya JES approach workaround, job arguments are case-sensitive and webout was not returned #845

merged 1 commit into from
Jun 9, 2025

Conversation

medjedovicm
Copy link
Member
@medjedovicm medjedovicm commented Jun 9, 2025 •
edited
Loading

Issue

https://documentation.sas.com/doc/zh-cn/sasadmincdc/v_021/caljobs/n0t21mf756sv0en1kd176kky8upt.htm

https://communities.sas.com/t5/SAS-Viya/Returning-webout-from-JES-API/td-p/966992

Intent

Sending request using JES API approach does not return _webout.json, because job argument _OMITSESSIONRESULTS is by default true and is case sensitive so we should send _omitSessionResults instead.

Checks

No PR (that involves a non-trivial code change) should be merged, unless all items below are confirmed! If an urgent fix is needed - use a tar file.

  • Unit tests coverage has been increased and a new threshold is set.
  • All sasjs-cli unit tests are passing (npm test).
  • (CI Runs this) All sasjs-tests are passing. If you want to run it manually (instructions available here).
  • Data Controller builds and is functional on both SAS 9 and Viya

@github-actions github-actions bot requested a review from YuryShkoda June 9, 2025 14:59
@github-actions GitHub Actions
Copy link
github-actions bot commented Jun 9, 2025

Coverage report

Total coverage

Status Category Percentage Covered / Total
🟡 Statements 65.01% 1852/2849
🔴 Branches 47.3% 761/1609
🔴 Functions 54.8% 308/562
🟡 Lines 69.98% 2770/3958

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 78f1178

@allanbowe
Copy link
Member

This issue is further discussed here: https://communities.sas.com/t5/SAS-Viya/Returning-webout-from-JES-API/td-p/966992

@allanbowe allanbowe merged commit 7e23b5d into master Jun 9, 2025
3 of 4 checks passed
@allanbowe allanbowe deleted the jes-workaround branch June 9, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allanbowe allanbowe allanbowe approved these changes

@YuryShkoda YuryShkoda Awaiting requested review from YuryShkoda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@medjedovicm @allanbowe
0