8000 fix: axios bump by medjedovicm · Pull Request #841 · sasjs/adapter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: axios bump #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Mar 14, 2025
Merged

fix: axios bump #841

merged 17 commits into from
Mar 14, 2025

Conversation

medjedovicm
Copy link
Member
@medjedovicm medjedovicm commented Feb 28, 2025 •
edited
Loading

Intent

Updating axios to get rid of vulnerabilities. Adapter bump is critical since it could fail on Viya, Sas9 or SASjs targets. If adapter tests pass, next big test is to install latest adapter in @sasj/cli and to pass the tests there too.

Checks

No PR (that involves a non-trivial code change) should be merged, unless all items below are confirmed! If an urgent fix is needed - use a tar file.

  • Unit tests coverage has been increased and a new threshold is set.
  • All sasjs-cli unit tests are passing (npm test).
  • (CI Runs this) All sasjs-tests are passing. If you want to run it manually (instructions available here).
  • Data Controller builds and is functional on both SAS 9 and Viya

SASjs Tests on Viya (Version: Stable 2024.12)

sas-viya-sasjs-tests-result.pdf

SASjs Tests on SAS9.4

sas9-sasjs-tests-result.pdf

@github-actions github-actions bot requested a review from YuryShkoda February 28, 2025 10:33
@github-actions GitHub Actions
Copy link
github-actions bot commented Mar 11, 2025 •
edited
Loading

Coverage report

Total coverage

Status Category Percentage Covered / Total
🟡 Statements 65.63% (+1.26% 🔼) 1852/2822
🔴 Branches 47.8% (+2.27% 🔼) 761/1592
🔴 Functions 55.9% (+1.48% 🔼) 308/551
🟡 Lines 70.83% (-3.96% 🔻) 2770/3911

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Show files with reduced coverage 🔻

Reduced coverage

Status Filename Statements Branches Functions Lines
🟡 src/auth/AuthManager.ts 77.21% (-1.96% 🔻) 47.89% (-9.43% 🔻) 78.95% (-1.05% 🔻) 72.92% (-2.56% 🔻)
🔴 src/types/errors/CertificateError.ts 40% (-22.5% 🔻) 100% (+100% 🔼) 0% (-50% 🔻) 0%
🟢 src/types/errors/JobExecutionError.ts 14.29% (-25.71% 🔻) 100% (+100% 🔼) 0% (-50% 🔻) 100%
🟢 src/types/errors/WeboutResponseError.ts 20% (-30% 🔻) 100% (+100% 🔼) 0% (-50% 🔻) 100%
🟢 src/utils/convertToCsv.ts 97.94% (-1.01% 🔻) 97.4% 100% 100%
🟢 src/auth/openWebPage.ts 100% 88.89% (-1.11% 🔻) 100% 100%
🟢 src/auth/verifySasViyaLogin.ts 100% (+7.69% 🔼) 45% (-3% 🔻) 100% 100%
🟡 src/request/RequestClient.ts 65.14% (-2.24% 🔻) 59.12% (+2.47% 🔼) 61.43% (+1.13% 🔼) 77.22% (-2.11% 🔻)
🟢 src/types/errors/InvalidSASjsCsrfError.ts 20% (-24.44% 🔻) 100% (+100% 🔼) 0% (-50% 🔻) 100%
🟢 src/SessionManager.ts 95.71% 81.48% 95.35% 98.17% (-1.83% 🔻)
🟢 src/api/viya/executeOnComputeApi.ts 92.63% (-1.28% 🔻) 81.71% (+3.14% 🔼) 86.67% 94.07% (+3.34% 🔼)
🟡 src/SASjs.ts 22.75% (-7.19% 🔻) 5.68% 7.69% (-1.92% 🔻) 68.42%
🔴 src/SASViyaApiClient.ts 25.95% (-5.4% 🔻) 17.18% (+1.67% 🔼) 15.87% (-1.31% 🔻) 26.21% (-36.62% 🔻)
🟢 src/ContextManager.ts 77.87% (-3.61% 🔻) 63.16% (-6.07% 🔻) 67.65% 87.39% (-4.81% 🔻)
🟢 src/api/viya/pollJobState.ts 96.99% 85.11% 100% 100%
🟢 src/auth/getAccessTokenForViya.ts 88.89% 33.33% 100% 100%
🔴 src/request/Sas9RequestClient.ts 27.91% (-3.67% 🔻) 6.67% (-7.62% 🔻) 6.25% (-5.51% 🔻) 5.71% (-27.96% 🔻)
🟢 src/request/SasjsRequestClient.ts 66.67% (-3.79% 🔻) 37.93% (-5.82% 🔻) 66.67% 96.36%
🔴 src/job-execution/ComputeJobExecutor.ts 23.08% (-10.26% 🔻) 0% (-11.11% 🔻) 10% (-8.18% 🔻) 0% (-24.56% 🔻)
🟡 src/job-execution/JobExecutor.ts 68.42% (-6.58% 🔻) 0% (-66.67% 🔻) 85.71% 66.67% (-11.59% 🔻)
🟡 src/job-execution/FileUploader.ts 77.97% (+2.97% 🔼) 52.78% (-1.28% 🔻) 81.82% (-1.52% 🔻) 72.94% (-24.56% 🔻)
🔴 src/job-execution/JesJobExecutor.ts 26.92% (-8.56% 🔻) 0% (-10.53% 🔻) 10% (-8.18% 🔻) 0% (-22.81% 🔻)
🔴 src/job-execution/Sas9JobExecutor.ts 22% (-7.09% 🔻) 0% (-5.88% 🔻) 14.29% (-10.71% 🔻) 9.72% (-24.26% 🔻)
🔴 src/job-execution/WebJobExecutor.ts 12.37% (-3.37% 🔻) 0% (-2.63% 🔻) 5.88% (-5.23% 🔻) 0% (-27.15% 🔻)
🔴 src/job-execution/SasjsJobExecutor.ts 22% (-5.27% 🔻) 0% (-5.26% 🔻) 10% (-8.18% 🔻) 0% (-26.5% 🔻)
🟢 src/api/viya/spec/mockResponses.ts 83.33% (-7.58% 🔻) 100% 0% (-25% 🔻) 100%
🟢 src/api/viya/getFileStream.ts 100% 62.5% (-7.5% 🔻) 100% 100%
🟢 src/api/viya/saveLog.ts 93.33% 57.14% 100% 86.67%

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from e3c4cb6

@medjedovicm medjedovicm mentioned this pull request Mar 11, 2025
Merged
10 tasks
@allanbowe allanbowe merged commit 3ec7375 into master Mar 14, 2025
3 checks passed
@allanbowe allanbowe deleted the bump-axios branch March 14, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allanbowe allanbowe allanbowe approved these changes

@YuryShkoda YuryShkoda Awaiting requested review from YuryShkoda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@medjedovicm @allanbowe @sabhas
0