Docs: Update ephemeral subdomains, remove Oasis link #3719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@orblivion Can you review this PR? |
|
Change looks fine, but why "most" users? Why not all or none? Was this documentation wrong before this fix? |
|
Is the wildcard hosting the only reason you say "most"? Then that answers my question. (in which case I'd say the documentation was wrong) |
|
👍 to merge though |
|
Yeah, if you tamper with the wildcard config you may have more things around the URL but there should always be a ui- in it for a grain view as of several years ago, and I just don't think this page was updated to reflect that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally most users will see a ui- prefix in their ephemeral subdomains, so I added this to some here to make this obvious. Note that if someone has a wildcard host config like alpha-*.example.com, they might have a ephemeral domain that looks like alpha-ui-45sda64dsfsd464ggdsg5.example.com, but that is uncommon enough I am not worried about clarifying it here.
Also, people cannot try this on Oasis.