Complement standard schema type #1581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request enhances validation consistency across the codebase by integrating the _createStandardSchema utility to wrap validation functions. Key changes include the update of the _createStandardSchema return type, the modification of generated test files (generate_index.ts and generate_plain.ts) to wrap validation functions using the utility, and the addition of a new debug test to validate this functionality.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/src/debug/standard-schema.ts | Added a simple debug test to verify the functionality of the wrapped validation function. |
| test/generate/output/generate_plain.ts | Modified to import and use _createStandardSchema when defining createValidate and createValidateEquals. |
| test/generate/output/generate_index.ts | Updated to wrap validation functions with _createStandardSchema for standardization. |
| src/internal/_createStandardSchema.ts | Enhanced the return type to include StandardSchemaV1, aligning the utility with schema standards. |
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the use of the
_createStandardSchemautility to wrap validation functions, enhancing standardization and consistency across the codebase. It also includes updates to the test files to integrate this utility and adds a new debug test for validation functionality.Integration of
_createStandardSchema:_createStandardSchemainsrc/internal/_createStandardSchema.tsto includeStandardSchemaV1, enabling schema standardization.Updates to generated test files:
test/generate/output/generate_index.tsandtest/generate/output/generate_plain.tsto import_createStandardSchemaand apply it to validation functions (validate,validateEquals,createValidate,createValidateEquals). These changes ensure that all validation functions are wrapped with the standardized schema utility. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]New debug test:
test/src/debug/standard-schema.tsto validate the functionality of_createStandardSchemaby testing a simple validation case for a number.