Fix mismatched ImGui::Alloc/Free #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The socket was being allocated with ImGui::MemAlloc but being freed with delete. When overriding the ImGui allocators, this mismatch causes a crash during disconnection.
|
The socket is allocated using ImGui::MemAlloc inside a placement new. The fix is missing manually calling the destructor of SocketInfo and then Imgui::MemFree. I will replace both the new( ImGui::MemMalloc )/delete, with netImguiNew/netImguiDelete like used everywhere else. |
|
Good point, I was focused on the memory and forgot about the destructor. Replacing with your standard way of doing it sounds great, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The socket was being allocated with ImGui::MemAlloc but being freed with delete. When overriding the ImGui allocators, this mismatch causes a crash during disconnection.