The invoice number is not available for use after an invoice is delete bug fix #1965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6364d9d to
c0f44f3
Compare
apoorv1316
reviewed
Apr 4, 2025
There was a problem hiding this comment.
@minakshin I would also write a spec for verifying that I am able to use the invoice number that was used in the discarded invoice.
|
@Shruti-Apte Please get it deployed on staging and test it. |
@apoorv1316 Updated test cases for spec to reuse discarded invoice number |
apoorv1316
approved these changes
Apr 4, 2025
d68b43b to
219cdb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github task - #1964
Changes
Screen.Recording.2025-04-04.at.12.27.39.PM.mov