8000 Upgrade Rails to 7.2 by apoorv1316 · Pull Request #1888 · saeloun/miru-web · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Upgrade Rails to 7.2 #1888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community. 8000

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Upgrade Rails to 7.2 #1888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7693ca2
upgrade-rails
apoorv1316 Aug 13, 2024
b16fa55
load 7-2
apoorv1316 Oct 24, 2024
9c35108
patch version
apoorv1316 Oct 24, 2024
d8aa113
update rexml
apoorv1316 Oct 24, 2024
b3dea85
Merge branch 'develop' into upgrade-to-rails-7-2
apoorv1316 Jan 15, 2025
06dcce3
rebase
apoorv1316 Jan 15, 2025
0f4fa6c 8000
audit gem fix
apoorv1316 Jan 15, 2025
5693739
try skip searchckick cb
apoorv1316 Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
< 10000 div class="js-split-diff-view d-flex flex-1">
26 changes: 10 additions & 16 deletions .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ require:
- rubocop-performance
- rubocop-rails
- rubocop-rspec
- rubocop-rspec_rails
- rubocop-factory_bot

AllCops:
TargetRubyVersion: 3.1.2
Expand Down Expand Up @@ -602,10 +604,10 @@ RSpec/ExpectInHook:
Enabled: true
StyleGuide: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExpectInHook

RSpec/FilePath:
Rails/FilePath:
Description: Checks that spec file paths are consistent and well-formed.
Enabled: true
StyleGuide: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/FilePath
StyleGuide: https://www.rubydoc.info/gems/rubocop-rails/RuboCop/Cop/Rails/FilePath

RSpec/HookArgument:
Description: Checks the arguments passed to before, around, and after.
Expand Down Expand Up @@ -739,29 +741,21 @@ RSpec/Rails/AvoidSetupHook:
Enabled: true
StyleGuide: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Rails/AvoidSetupHook

RSpec/Rails/HttpStatus:
Rails/HttpStatus:
Description:
Enforces use of symbolic or numeric value to describe HTTP status.
Enabled: true
StyleGuide: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Rails/HttpStatus
StyleGuide: https://www.rubydoc.info/gems/rubocop-rails/RuboCop/Cop/Rails/HttpStatus

# RSpec x FactoryBot
RSpec/FactoryBot/AttributeDefinedStatically:
Description: Always declare attribute values as blocks.
FactoryBot/AttributeDefinedStatically:
Enabled: true
StyleGuide: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/FactoryBot/AttributeDefinedStatically

RSpec/FactoryBot/CreateList:
Description: Checks for create_list usage.
FactoryBot/CreateList:
Enabled: true
StyleGuide: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/FactoryBot/CreateList

RSpec/FactoryBot/FactoryClassName:
Description: Use string value when setting the class attribute explicitly.
FactoryBot/FactoryClassName:
Enabled: true
StyleGuide: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/FactoryBot/FactoryClassName

RSpec/FactoryBot/SyntaxMethods:
Description: Use shorthands from FactoryBot::Syntax::Methods in your specs.
FactoryBot/SyntaxMethods:
Enabled: true
StyleGuide: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/FactoryBot/SyntaxMethods
5 changes: 4 additions & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ git_source(:github) { |repo| "https://github.com/#{repo}.git" }
ruby "3.2.4"

# Bundle edge Rails instead: gem "rails", github: "rails/rails", branch: "main"
gem "rails", "~> 7.1.5"
gem "rails", "~> 7.2.2"

# Use postgresql as the database for Active Record
gem "pg"
Expand Down Expand Up @@ -162,6 +162,9 @@ group :development, :test, :ci do
# Use factory-bot to replace fixtures
gem "factory_bot_rails"

gem "rubocop-factory_bot"
gem "rubocop-rspec_rails"

# Use Faker for fake data
gem "faker"

Expand Down
Loading
Loading
0