-
Notifications
You must be signed in to change notification settings - Fork 75
Added logic for days per week and day per year leave scenerio #1720
New issue
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c9146fc
to
f22db20
Compare
nisusam
requested changes
Mar 20, 2024
Comment on lines
175
to
177
current_date = DateTime.now | ||
current_year = current_date.year | ||
current_month = current_date.month |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Define this on top & reuse the same in each method
def quarter_position_and_after_mid_quarter(date) | ||
case date.month | ||
when 1..3 | ||
quarter = 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quarter = (date.month / 3.0).ceil
case date.month | ||
when 1..3 | ||
quarter = 1 | ||
mid_date = Date.new(date.year, 1, 1) + 1.month + 15.days # January 15th |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mid_ A4AB date = Date.new(date.year, (((quarter - 1) * 3) + 2, 1) + 15.days
nisusam
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.