Optional holiday lapses #1727
Merged
Optional holiday lapses #1727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisusam
requested changes
Mar 19, 2024
| leave_date: start_of_quarter..end_of_quarter, | ||
| user:).count | ||
| when :per_year | ||
| total_optional_entries = optional_timeoff_entries.where(user:).count |
There was a problem hiding this comment.
leave_date should be filtered based on year
There was a problem hiding this comment.
We are filtering optional_timeoff_entries from holidays and holidays are unique for each year. The entries are getting filtered based on the holiday year.
apoorv1316
approved these changes
Mar 20, 2024
nisusam
requested changes
Mar 20, 2024
nisusam
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
We can't apply for optional holiday more than the defined optional holidays. It will throw the following error message "You have exceeded the maximum number of permitted optional holidays". For example, if the admin defined one optional holiday for one quarter then the employee can apply for more than one optional holiday in the same quarter.
We can't apply for two holidays on the same day. It will throw the following error message "You are adding two holidays on the same day, please recheck".