8000 Remove partial and use jbuilder itself by nisusam · Pull Request #1719 · saeloun/miru-web · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove partial and use jbuilder itself #1719

8000 New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2024
Merged

Remove partial and use jbuilder itself #1719

merged 1 commit into from
Mar 18, 2024

Conversation

nisusam
Copy link
Collaborator
@nisusam nisusam commented Mar 15, 2024
  • Fixes Partial files rendered multiple times #1697
  • In this case, each timesheet_entry and timeoff_entry from the time tracking page are rendered in their own partial
  • There is no need for partial in this case
  • Hence, removed the same and used JBuilder itself

Remove partial and use jbuilder itself
7fc12b0 
- Fixes #1697
- In this case, each timesheet_entry and timeoff_entry from time
  tracking page are rendered in their own partial
- There is no need of partial in this case
- Hence, removed the same and used jbuilder itself
@prasanthchaduvula prasanthchaduvula merged commit 805a59c into develop Mar 18, 2024
@prasanthchaduvula prasanthchaduvula deleted the remove_partials branch March 18, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SiddharthShringi SiddharthShringi SiddharthShringi approved these changes

@prasanthchaduvula prasanthchaduvula prasanthchaduvula approved these changes

@apoorv1316 apoorv1316 Awaiting requested review from apoorv1316

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Partial files rendered multiple times
3 participants
@nisusam @SiddharthShringi @prasanthchaduvula
0