Devices API #1699
Merged
Devices API #1699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 22, 2024 15:15
6563a42 to
01e3c32
Compare
This reverts commit 9d5bda3.
nisusam
requested changes
Jun 10, 2024
| @@ -39,7 +32,11 @@ def device | |||
|
|
|||
| def device_params | |||
| params.require(:device).permit( | |||
| :device_type, :name, :serial_number, specifications: {} | |||
| add_devices: [:device_type, :name, :serial_number, :is_insured, :insurance_bought_date, :insurance_expiry_date, | |||
There was a problem hiding this comment.
expected_attributes = [:device_type, :name, :serial_number, :is_insured, :insurance_bought_date, :insurance_expiry_date, specifications: [:processor, :ram, :graphics]]
add_devices: expected_attributes,
update_devices: expected_attributes + [:id]
remove_devices: []
app/models/device.rb
Outdated
| # user_id :bigint not null | ||
| # id :bigint not null, primary key | ||
| # device_type :string default("laptop") | ||
| # insurance_bought_date :date |
There was a problem hiding this comment.
Is insurance_bought_date == insurance_start_date?
There was a problem hiding this comment.
using insurance_activation_date now
nisusam
approved these changes
Jun 26, 2024
apoorv1316
added a commit
that referenced
this pull request
Jun 26, 2024
This reverts commit 2b874c7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What