8000 Expense module: UI and Integration by Shruti-Apte · Pull Request #1625 · saeloun/miru-web · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Expense module: UI and Integration #1625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Mar 8, 2024
Merged

Expense module: UI and Integration #1625

merged 19 commits into from
Mar 8, 2024

Conversation

Shruti-Apte
Copy link
Contributor
@Shruti-Apte Shruti-Apte commented Jan 9, 2024 •
edited
Loading

What

  1. UI for all pages.
  2. Edit and Delete methods added expense_controller
  3. API Integration
  4. Mobile responsive pages.

Preview:
Screenshot 2024-01-09 at 4 23 12 PM

Screenshot 2024-01-09 at 4 22 42 PM Screenshot 2024-01-09 at 4 22 50 PM Screenshot 2024-01-09 at 4 23 26 PM Screenshot 2024-01-09 at 4 23 36 PM

What's Remaining

  • Download expense functionality.
  • Expense summary API and integration
  • PieChart
  • Client list API is not present

@Shruti-Apte Shruti-Apte requested a review from JijoBose January 10, 2024 10:59
JijoBose
JijoBose requested changes Jan 12, 2024
View reviewed changes
Copy link
Contributor
@JijoBose JijoBose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-01-12 at 1 38 08 PM

8000
@JijoBose
Copy link
Contributor
JijoBose commented Jan 16, 2024 •
edited
Loading

@Shruti-Apte Filter button has no functionality,
Should we remove it, if it's not part of this Ticket?

@apoorv1316
Copy link
Collaborator

@Shruti-Apte Please work on changes discussed on call

@JijoBose JijoBose requested review from nisusam and removed request for JijoBose January 29, 2024 11:06
apoorv1316
apoorv1316 requested changes Mar 1, 2024
View reviewed changes
Copy link
Collaborator
@apoorv1316 apoorv1316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shruti-Apte Please fix the requested changes

@Shruti-Apte Shruti-Apte requested a review from nisusam March 6, 2024 08:07
apoorv1316
apoorv1316 approved these changes Mar 8, 2024
View reviewed changes
Copy link
Collaborator
@apoorv1316 apoorv1316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some requirements are yet to be implemented. Let's do it in upcoming PR.

@apoorv1316 apoorv1316 merged commit c8f6fb9 into develop Mar 8, 2024
@apoorv1316 apoorv1316 deleted the expense_module branch March 8, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JijoBose JijoBose JijoBose requested changes

@nisusam nisusam nisusam approved these changes

@apoorv1316 apoorv1316 apoorv1316 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Shruti-Apte @JijoBose @apoorv1316 @nisusam
0